Skip to content

[FLINK-10540] Remove legacy FlinkMiniCluster and sub classes #7694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asfgit merged 4 commits into from
Feb 18, 2019
Merged

[FLINK-10540] Remove legacy FlinkMiniCluster and sub classes #7694

asfgit merged 4 commits into from
Feb 18, 2019

Conversation

@tillrohrmann
Copy link
Contributor

@tillrohrmann tillrohrmann commented Feb 13, 2019

What is the purpose of the change

Remove legacy FlinkMiniCluster and sub classes.

This PR is based on #7693.

Brief change log

This commit removes

  • FlinkMiniCluster
  • LocalFlinkMiniCluster
  • TestingCluster

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 13, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❌ 1. The [description] looks good.
  • ❌ 2. There is [consensus] that the contribution should go into to Flink.
  • ❔ 3. Needs [attention] from.
  • ❌ 4. The change fits into the overall [architecture].
  • ❌ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot approve description to approve the 1st aspect (similarly, it also supports the consensus, architecture and quality keywords)
  • @flinkbot approve all to approve all aspects
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval

zentol
zentol approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the removal.

tisonkun
tisonkun approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the removal and it will unblock several removals of legacy code in "client" componenet.

@zentol zentol self-assigned this Feb 15, 2019
@tillrohrmann tillrohrmann force-pushed the FLINK-10540 branch 2 times, most recently from f82200e to 1a766c9 Compare February 18, 2019 08:44
@tillrohrmann
Copy link
Contributor Author

tillrohrmann commented Feb 18, 2019

Thanks for the review @zentol and @tisonkun. Merging after a rebase.

@tillrohrmann
[hotfix] Move testing sender and receiver invokables to TestingAbstra…
9bf4ea9 
…ctInvokables

Moves the testing Sender and Receiver class from JobExecutionITCase to TestingAbstractInvokables
for easier reusability.
@tillrohrmann
[FLINK-11592][tests] Port TaskManagerFailsWithSlotSharingITCase to ne…
3a92a87 
…w code base

- "handle gracefully failing task manager with slot sharing" --> TaskExecutorITCase#testJobReExecutionAfterTaskExecutorTermination
- "handle hard failing task manager with slot sharing" --> TaskExecutorITCase#testJobReExecutionAfterTaskExecutorTermination

This commit changes the JobGraph of the TaskExecutorITCase such that it uses now slot sharing.

This closes apache#7693.
@tillrohrmann
[hotfix][tests] Remove Tasks#Sender and #Receiver
c66e0d5
@tillrohrmann
[FLINK-10540] Remove legacy FlinkMiniCluster and sub classes
c3b339c 
This commit removes

- FlinkMiniCluster
- LocalFlinkMiniCluster
- TestingCluster

This closes apache#7694.
@tillrohrmann tillrohrmann mentioned this pull request Feb 18, 2019
Closed
@tillrohrmann tillrohrmann deleted the FLINK-10540 branch February 18, 2019 12:23
@asfgit asfgit merged commit c3b339c into apache:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zentol zentol zentol approved these changes

@tisonkun tisonkun tisonkun approved these changes

Assignees

@zentol zentol

Labels

component=<none>

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tillrohrmann @flinkbot @zentol @tisonkun @rmetzger @asfgit